Qodana for C/C++

24 new problems were found

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

This pull request is open for testing, please be aware that it may contain a lot of bugs, if you find anything out of order that was not supposed to happen, please report commenting in here.

Apparently, the getWorldConfigsById function, which is called in CanaryServer::loadThisWorld, is returning an invalid value, causing errors later on.

canary_server.cpp line 150

Error on line 176 becouse world->type is invalid?

Apparently, the getWorldConfigsById function, which is called in CanaryServer::loadThisWorld, is returning an invalid value, causing errors later on.

canary_server.cpp line 150

Error on line 176 becouse world->type is invalid?

something in your config.lua could be wrong. by the way, i'll check.

something in your config.lua could be wrong. by the way, i'll check.

I've checked the config.lua I'm using and the config.lua.dist. Aside from some settings like database access, server name, and rate, I added the toggleServerIsRetroPVP configuration as false.

Below is the difference between the two files (on the left is config.lua.dist).

https://www.diffchecker.com/ZgLRqJEy/

[warning] [ConfigManager::missingConfigWarning]: Missing configuration for identifier: toggleServerIsRetroPVP

[warning] [ConfigManager::missingConfigWarning]: Missing configuration for identifier: toggleServerIsRetroPVP

now we use the server type from database.

something in your config.lua could be wrong. by the way, i'll check.

I've checked the config.lua I'm using and the config.lua.dist. Aside from some settings like database access, server name, and rate, I added the toggleServerIsRetroPVP configuration as false.

Below is the difference between the two files (on the left is config.lua.dist).

https://www.diffchecker.com/ZgLRqJEy/

From what I've seen while debugging, the function getWorldConfigsById is always receiving an empty ID (or is ignoring the received parameter???).

In this test I've performed, "Received ID: " is always printed, even though the variable worldId is set correctly.

Could it be a type mismatch?

something in your config.lua could be wrong. by the way, i'll check.

I've checked the config.lua I'm using and the config.lua.dist. Aside from some settings like database access, server name, and rate, I added the toggleServerIsRetroPVP configuration as false.
Below is the difference between the two files (on the left is config.lua.dist).
https://www.diffchecker.com/ZgLRqJEy/

From what I've seen while debugging, the function getWorldConfigsById is always receiving an empty ID (or is ignoring the received parameter???).

In this test I've performed, "Received ID: " is always printed, even though the variable worldId is set correctly.

Could it be a type mismatch?

do you have table worlds updated with recent changes? and your config.lua has worldId with the same in table worlds?

do you have table worlds updated with recent changes? and your config.lua has worldId with the same in table worlds?

After the last update, this isn't occurring anymore.

I've been running this version for a couple of days. Everything seems fine. I've tested guilds, market, war, character creation, etc. I believe I now need to test Myacc a bit more, but regarding Canary, I haven't found any problems.

Qodana for C/C++

1040 new problems were found

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

This PR is stale because it has been open 45 days with no activity.

This PR is stale because it has been open 45 days with no activity.